[Xen-changelog] [xen master] x86/EFI: permit setting variable with non-zero attributes

[patchbot@xxxxxxx]

commit 78380c34dfeb27da3d0222bcb7232c5d8e2f5b30
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Mar 27 08:46:28 2013 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Mar 27 08:46:28 2013 +0100

    x86/EFI: permit setting variable with non-zero attributes
    
    This must have been a copy-and-paste mistake - get_variable uses
    op->misc as output only, and wants to make sure it's zero for future
    extensibility. For set_variable, this is an input though, and hence
    the check is wrong.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Keir Fraser <keir@xxxxxxx>
---
 xen/arch/x86/efi/runtime.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/efi/runtime.c b/xen/arch/x86/efi/runtime.c
index 73aa15e..aafdfeb 100644
--- a/xen/arch/x86/efi/runtime.c
+++ b/xen/arch/x86/efi/runtime.c
@@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
         long len;
         unsigned char *data;
 
-        if ( op->misc )
-            return -EINVAL;
-
         len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
         if ( len < 0 )
             return len;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog