[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-upstream-unstable] Fix off-by-1 error in RAM migration code

commit 3b4fc1f9d202d6faade11df9bb6c1dcd61e72b08
Author:     David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
AuthorDate: Tue Dec 4 11:38:38 2012 +1100
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Mon Jan 14 15:40:38 2013 -0600

    Fix off-by-1 error in RAM migration code
    The code for migrating (or savevm-ing) memory pages starts off by creating
    a dirty bitmap and filling it with 1s.  Except, actually, because bit
    addresses are 0-based it fills every bit except bit 0 with 1s and puts an
    extra 1 beyond the end of the bitmap, potentially corrupting unrelated
    memory.  Oops.  This patch fixes it.
    Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
    (cherry picked from commit 7ec81e56edc2b2007ce0ae3982aa5c18af9546ab)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
 arch_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index e6effe8..b75a4c5 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -568,7 +568,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
     int64_t ram_pages = last_ram_offset() >> TARGET_PAGE_BITS;
     migration_bitmap = bitmap_new(ram_pages);
-    bitmap_set(migration_bitmap, 1, ram_pages);
+    bitmap_set(migration_bitmap, 0, ram_pages);
     migration_dirty_pages = ram_pages;
     bytes_transferred = 0;
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.