[Xen-changelog] [xen master] io/ring.h: drop unused and broken *_RING_ATTACH() macros

[patchbot@xxxxxxx]

commit 613659da9b1755ddf0a291071f6551a0ad25419b
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Jun 12 10:07:48 2013 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Jun 12 10:07:48 2013 +0200

    io/ring.h: drop unused and broken *_RING_ATTACH() macros
    
    Initializing r*_prod_pvt and r*_cons from independent shared ring
    fields is broken, as other macros in this header rely on them being
    coupled. Furthermore using the backend variant would also imply a
    security vulnerability.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Keir Fraser <keir@xxxxxxx>
---
 xen/include/public/io/ring.h |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/xen/include/public/io/ring.h b/xen/include/public/io/ring.h
index bdfb998..73e13d7 100644
--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -174,21 +174,6 @@ typedef struct __name##_back_ring __name##_back_ring_t
     (_r)->sring = (_s);                                                 \
 } while (0)
 
-/* Initialize to existing shared indexes -- for recovery */
-#define FRONT_RING_ATTACH(_r, _s, __size) do {                          \
-    (_r)->sring = (_s);                                                 \
-    (_r)->req_prod_pvt = (_s)->req_prod;                                \
-    (_r)->rsp_cons = (_s)->rsp_prod;                                    \
-    (_r)->nr_ents = __RING_SIZE(_s, __size);                            \
-} while (0)
-
-#define BACK_RING_ATTACH(_r, _s, __size) do {                           \
-    (_r)->sring = (_s);                                                 \
-    (_r)->rsp_prod_pvt = (_s)->rsp_prod;                                \
-    (_r)->req_cons = (_s)->req_prod;                                    \
-    (_r)->nr_ents = __RING_SIZE(_s, __size);                            \
-} while (0)
-
 /* How big is this ring? */
 #define RING_SIZE(_r)                                                   \
     ((_r)->nr_ents)
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog