[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] libelf: move include of <asm/guest_access.h> to top of file

commit f7aa72ec00aec71eed055dac5e8a151966d75c9c
Author:     Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
AuthorDate: Fri Jun 14 16:39:35 2013 +0100
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Fri Jun 14 16:39:35 2013 +0100

    libelf: move include of <asm/guest_access.h> to top of file
    libelf-loader.c #includes <asm/guest_access.h>, when being compiled
    for Xen.  Currently it does this in the middle of the file.
    Move this #include to the top of the file, before libelf-private.h.
    This is necessary because in forthcoming patches we will introduce
    private #defines of memcpy etc. which would interfere with definitions
    in headers #included from guest_access.h.
    No semantic or functional change in this patch.
    This is part of the fix to a security issue, XSA-55.
    Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Chuck Anderson <chuck.anderson@xxxxxxxxxx>
 xen/common/libelf/libelf-loader.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/xen/common/libelf/libelf-loader.c 
index bce667f..94257f6 100644
--- a/xen/common/libelf/libelf-loader.c
+++ b/xen/common/libelf/libelf-loader.c
@@ -16,6 +16,10 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  
+#ifdef __XEN__
+#include <asm/guest_access.h>
 #include "libelf-private.h"
 /* ------------------------------------------------------------------------ */
@@ -116,7 +120,6 @@ static int elf_load_image(struct elf_binary *elf,
     return 0;
-#include <asm/guest_access.h>
 void elf_set_verbose(struct elf_binary *elf)
generated by git-patchbot for /home/xen/git/xen.git#master

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.