[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen stable-4.1] AMD IOMMU: add missing check



commit 560691065225cc060236ae1c2ba7e3ff8349c485
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Fri Sep 6 15:43:07 2013 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Sep 6 15:43:07 2013 +0200

    AMD IOMMU: add missing check
    
    We shouldn't accept IVHD tables specifying IO-APIC IDs beyond the limit
    we support (MAX_IO_APICS, currently 128).
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Suravee Suthikulpanit <suravee.suthikulapanit@xxxxxxx>
    master commit: 3785d30efe8264b899499e0883b10cc434bd0959
    master date: 2013-08-29 09:31:37 +0200
---
 xen/drivers/passthrough/amd/iommu_acpi.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c 
b/xen/drivers/passthrough/amd/iommu_acpi.c
index 7352438..0aeeb30 100644
--- a/xen/drivers/passthrough/amd/iommu_acpi.c
+++ b/xen/drivers/passthrough/amd/iommu_acpi.c
@@ -677,6 +677,13 @@ static u16 __init parse_ivhd_device_special(
         if ( IO_APIC_ID(apic) != ivhd_device->special.handle )
             continue;
 
+        if ( ivhd_device->special.handle >= MAX_IO_APICS )
+        {
+            printk(XENLOG_ERR "IVHD Error: IO-APIC %#x entry beyond bounds\n",
+                   ivhd_device->special.handle);
+            return 0;
+        }
+
         if ( ioapic_bdf[ivhd_device->special.handle].pin_setup )
         {
             if ( ioapic_bdf[ivhd_device->special.handle].bdf == bdf )
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.1

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.