[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] xenstored: fix faulty check for bad handle in domain_init



commit 07fa854a43bfb52fb4abfe7865ef1fb0467bdba7
Author:     Matthew Daley <mattjd@xxxxxxxxx>
AuthorDate: Wed Sep 18 15:37:55 2013 +1200
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Wed Sep 25 13:23:12 2013 +0100

    xenstored: fix faulty check for bad handle in domain_init
    
    Coverity-ID: 1054975
    Coverity-ID: 1055196
    Signed-off-by: Matthew Daley <mattjd@xxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/xenstore/xenstored_domain.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/xenstore/xenstored_domain.c 
b/tools/xenstore/xenstored_domain.c
index bf83d58..f24bd6b 100644
--- a/tools/xenstore/xenstored_domain.c
+++ b/tools/xenstore/xenstored_domain.c
@@ -640,7 +640,7 @@ void domain_init(void)
                barf_perror("Failed to allocate domain gnttab handle");
 
        *xcg_handle = xc_gnttab_open(NULL, 0);
-       if (*xcg_handle < 0)
+       if (*xcg_handle == NULL)
                xprintf("WARNING: Failed to open connection to gnttab\n");
        else
                talloc_set_destructor(xcg_handle, close_xcg_handle);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.