[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] libxenstore: Use PTHREAD_STACK_MIN



commit 35e874b1d5d56dd2098313364b879c637fa56844
Author:     Ian Campbell <ian.campbell@xxxxxxxxxx>
AuthorDate: Fri Oct 25 08:47:35 2013 +0100
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Mon Oct 28 15:33:04 2013 +0000

    libxenstore: Use PTHREAD_STACK_MIN
    
    The existing value of 16K is smaller than the arm64 minimum stack size, 
which
    is 128K. PTHREAD_STACK_MIN appears to be standard
    
http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_attr_setstacksize.html
    
    Consindered setting a lower bound but the stack requirements of the watcher
    thread are pretty minimal (tens of bytes from the looks of it) and unlikely 
to
    blow PTHREAD_STACK_MIN on any useful platform.
    
    Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 tools/xenstore/xs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/xenstore/xs.c b/tools/xenstore/xs.c
index b1e6820..261b841 100644
--- a/tools/xenstore/xs.c
+++ b/tools/xenstore/xs.c
@@ -723,7 +723,7 @@ bool xs_watch(struct xs_handle *h, const char *path, const 
char *token)
        struct iovec iov[2];
 
 #ifdef USE_PTHREAD
-#define READ_THREAD_STACKSIZE (16 * 1024)
+#define READ_THREAD_STACKSIZE PTHREAD_STACK_MIN
 
        /* We dynamically create a reader thread on demand. */
        mutex_lock(&h->request_mutex);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.