[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-upstream-unstable] pseries: Fix stalls on hypervisor virtual console



commit 3fe494efc5eb107c4c90e96df3e6131f9960f4b9
Author:     Anton Blanchard <anton@xxxxxxxxx>
AuthorDate: Tue Aug 13 14:10:04 2013 +1000
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Tue Sep 24 19:23:18 2013 -0500

    pseries: Fix stalls on hypervisor virtual console
    
    A number of users are reporting stalls when using the pseries
    hypervisor virtual console.
    
    A simple test case is to paste 15 or 17 characters at a time
    into the console. Pasting 15 characters at a time works fine
    but pasting 17 characters hangs for a random amount of time.
    Other activity (network, qemu monitor etc) unblocks it.
    
    If qemu-char tries to send more than 16 characters at once,
    vty_can_receive returns false. At this point we have to
    wait for the guest to consume that output. Everything is good
    so far.
    
    The problem occurs when the the guest does consume the output.
    We need to signal back to the qemu-char layer that we are
    ready for more input. Without this we block until something
    else kicks us (eg network activity).
    
    Signed-off-by: Anton Blanchard <anton@xxxxxxxxx>
    Signed-off-by: Alexander Graf <agraf@xxxxxxx>
    (cherry picked from commit 7770b6f78a2d655e03852a5de238f5926c92be6a)
    
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/char/spapr_vty.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index a799721..9c2aef8 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -47,6 +47,8 @@ static int vty_getchars(VIOsPAPRDevice *sdev, uint8_t *buf, 
int max)
         buf[n++] = dev->buf[dev->out++ % VTERM_BUFSIZE];
     }
 
+    qemu_chr_accept_input(dev->chardev);
+
     return n;
 }
 
--
generated by git-patchbot for /home/xen/git/qemu-upstream-unstable.git

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.