[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] libxl: ocaml: remove dead code in xentoollog bindings



commit f290d0cb3142606faf13dc9bc76766631cc17e92
Author:     Rob Hoes <rob.hoes@xxxxxxxxxx>
AuthorDate: Mon Dec 9 15:17:30 2013 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Tue Dec 10 13:34:53 2013 +0000

    libxl: ocaml: remove dead code in xentoollog bindings
    
    Found by Coverty. CIDs: 1128567 1128568 1128576 1128577.
    
    Signed-off-by: Rob Hoes <rob.hoes@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: David Scott <dave.scott@xxxxxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/ocaml/libs/xentoollog/xentoollog_stubs.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c 
b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
index 3b2f91b..122ed0d 100644
--- a/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
+++ b/tools/ocaml/libs/xentoollog/xentoollog_stubs.c
@@ -87,8 +87,6 @@ static void stub_xtl_ocaml_vmessage(struct xentoollog_logger 
*logger,
        value *func = caml_named_value(xtl->vmessage_cb) ;
        char *msg;
 
-       if (args == NULL)
-               caml_raise_out_of_memory();
        if (func == NULL)
                caml_raise_sys_error(caml_copy_string("Unable to find 
callback"));
        if (vasprintf(&msg, format, al) < 0)
@@ -116,8 +114,6 @@ static void stub_xtl_ocaml_progress(struct 
xentoollog_logger *logger,
        struct caml_xtl *xtl = (struct caml_xtl*)logger;
        value *func = caml_named_value(xtl->progress_cb) ;
 
-       if (args == NULL)
-               caml_raise_out_of_memory();
        if (func == NULL)
                caml_raise_sys_error(caml_copy_string("Unable to find 
callback"));
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.