[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] libxl: fix unsigned less-than-0 comparison in e820_sanitize
commit 5d71457def05299bfa69276bb7f31db705f05f19 Author: Matthew Daley <mattd@xxxxxxxxxxx> AuthorDate: Sun Dec 1 23:14:55 2013 +1300 Commit: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> CommitDate: Fri Dec 13 17:30:52 2013 +0000 libxl: fix unsigned less-than-0 comparison in e820_sanitize Both src[i].size and delta are unsigned, so checking their difference for being less than 0 doesn't work. Coverity-ID: 1055615 Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> --- tools/libxl/libxl_x86.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index e1c183f..b11d036 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -125,7 +125,7 @@ static int e820_sanitize(libxl_ctx *ctx, struct e820entry src[], src[i].type = E820_UNUSABLE; delta = ram_end - src[i].addr; /* The end < ram_end should weed this out */ - if (src[i].size - delta < 0) + if (src[i].size < delta) src[i].type = 0; else { src[i].size -= delta; -- generated by git-patchbot for /home/xen/git/xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |