[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen stable-4.2] tools/xc_restore: Initialise console and store mfns

commit fb6525f7e12fc8c707f3a12dd09655dddbbc16bb
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Mon Nov 25 11:05:47 2013 +0000
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Thu Jan 9 12:37:52 2014 +0000

    tools/xc_restore: Initialise console and store mfns
    If the console or store mfn chunks are not present in the migration stream,
    stack junk gets reported for the mfns.
    XenServer had a very hard to track down VM corruption issue caused by 
    this issue.  Xenconsoled would connect to a junk mfn and incremented the 
    pointer if the junk happend to look like a valid gfn.
    Coverity ID: 1056093 1056094
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    (cherry picked from commit 592b614f3469bb83d1158c3dc8c15b67aacfbf4f)
    (cherry picked from commit 6d7b67c67039ceac36a780b59c2b890739094b95)
 tools/xcutils/xc_restore.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/xcutils/xc_restore.c b/tools/xcutils/xc_restore.c
index 0235579..81ff165 100644
--- a/tools/xcutils/xc_restore.c
+++ b/tools/xcutils/xc_restore.c
@@ -23,7 +23,7 @@ main(int argc, char **argv)
     xc_interface *xch;
     int io_fd, ret;
     int superpages;
-    unsigned long store_mfn, console_mfn;
+    unsigned long store_mfn = 0, console_mfn = 0;
     if ( (argc != 8) && (argc != 9) )
         errx(1, "usage: %s iofd domid store_evtchn "
generated by git-patchbot for /home/xen/git/xen.git#stable-4.2

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.