[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen stable-4.3] libxl: actually abort if initializing a ctx's lock fails

commit 62f88c08b31259032c81163f4133d6f25f033c1e
Author:     Matthew Daley <mattd@xxxxxxxxxxx>
AuthorDate: Sun Dec 1 23:15:00 2013 +1300
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Thu Jan 9 12:24:53 2014 +0000

    libxl: actually abort if initializing a ctx's lock fails
    If initializing the ctx's lock fails, don't keep going, but instead
    error out.
    Coverity-ID: 1055289
    Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
    Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
    (cherry picked from commit b1cb2bdde1f2393d75a925e6c15862b93d3e7abd)
 tools/libxl/libxl.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index f447b9e..00430fb 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -74,6 +74,8 @@ int libxl_ctx_alloc(libxl_ctx **pctx, int version,
         LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "Failed to initialize mutex");
         ctx = 0;
+        rc = ERROR_FAIL;
+        goto out;
     /* Now ctx is safe for ctx_free; failures simply set rc and "goto out" */
generated by git-patchbot for /home/xen/git/xen.git#stable-4.3

Xen-changelog mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.