[Xen-changelog] [xen stable-4.2] x86/irq: avoid use-after-free on error path in pirq_guest_bind()

[patchbot@xxxxxxx]

commit 85c4e39100037fafc4e4c3e517aaef8180ffdde7
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Thu Jan 23 13:59:35 2014 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Jan 23 13:59:35 2014 +0100

    x86/irq: avoid use-after-free on error path in pirq_guest_bind()
    
    This is XSA-83.
    
    Coverity-ID: 1146952
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
    master commit: 650fc2f76d0a156e23703683d0c18fa262ecea36
    master date: 2014-01-23 13:55:42 +0100
---
 xen/arch/x86/irq.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c
index f3d86a8..be34dcb 100644
--- a/xen/arch/x86/irq.c
+++ b/xen/arch/x86/irq.c
@@ -1574,8 +1574,7 @@ int pirq_guest_bind(struct vcpu *v, struct pirq *pirq, 
int will_share)
             printk(XENLOG_G_INFO
                    "Cannot bind IRQ%d to dom%d. Out of memory.\n",
                    pirq->pirq, v->domain->domain_id);
-            rc = -ENOMEM;
-            goto out;
+            return -ENOMEM;
         }
 
         action = newaction;
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.2

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog