[Xen-changelog] [xen master] x86/hvm/rtc: always deassert the IRQ line when clearing REG_C.IRQF

[patchbot@xxxxxxx]

commit 6d27a537727ca933bfef8ba01bc65847dc97cee1
Author:     Tim Deegan <tim@xxxxxxx>
AuthorDate: Tue Feb 25 09:30:21 2014 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Feb 25 09:30:21 2014 +0100

    x86/hvm/rtc: always deassert the IRQ line when clearing REG_C.IRQF
    
    Even in no-ack mode, there's no reason to leave the line asserted
    after an explicit ack of the interrupt.
    
    Furthermore, rtc_update_irq() is an unconditional noop having just cleared
    REG_C.
    
    Signed-off-by: Tim Deegan <tim@xxxxxxx>
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/hvm/rtc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c
index d641d95..639b4c5 100644
--- a/xen/arch/x86/hvm/rtc.c
+++ b/xen/arch/x86/hvm/rtc.c
@@ -673,9 +673,8 @@ static uint32_t rtc_ioport_read(RTCState *s, uint32_t addr)
         check_for_pf_ticks(s);
         ret = s->hw.cmos_data[s->hw.cmos_index];
         s->hw.cmos_data[RTC_REG_C] = 0x00;
-        if ( (ret & RTC_IRQF) && !rtc_mode_is(s, no_ack) )
+        if ( ret & RTC_IRQF )
             hvm_isa_irq_deassert(d, RTC_IRQ);
-        rtc_update_irq(s);
         check_update_timer(s);
         alarm_timer_update(s);
         s->pt_dead_ticks = 0;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog