[Xen-changelog] [xen master] libxl: Hold the atfork lock while closing carefd

[patchbot@xxxxxxx]

commit 2a0c3a62ea4ad6c6bcbf80122b070f3ff3fe7dae
Author:     Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
AuthorDate: Mon Feb 24 14:19:14 2014 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Thu Mar 13 12:50:07 2014 +0000

    libxl: Hold the atfork lock while closing carefd
    
    This avoids the process being forked while a carefd is recorded in the
    list but the actual fd has been closed.  If that happened, a
    subsequent libxl_postfork_child_noexec would attempt to close the fd
    again.  If we are lucky that results in a harmless warning; but if we
    are unlucky the fd number has been reused and we close an unrelated
    fd.
    
    This race has not been observed anywhere as far as we are aware.
    
    Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
    Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
    CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
---
 tools/libxl/libxl_fork.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/libxl/libxl_fork.c b/tools/libxl/libxl_fork.c
index 8421296..fa15095 100644
--- a/tools/libxl/libxl_fork.c
+++ b/tools/libxl/libxl_fork.c
@@ -184,9 +184,9 @@ void libxl_postfork_child_noexec(libxl_ctx *ctx)
 int libxl__carefd_close(libxl__carefd *cf)
 {
     if (!cf) return 0;
+    atfork_lock();
     int r = cf->fd < 0 ? 0 : close(cf->fd);
     int esave = errno;
-    atfork_lock();
     LIBXL_LIST_REMOVE(cf, entry);
     atfork_unlock();
     free(cf);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog