[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [linux-2.6.18-xen] scsiback: correct grant page unmapping


  • To: xen-changelog@xxxxxxxxxxxxxxxxxxx
  • From: Xen patchbot-linux-2.6.18-xen <patchbot@xxxxxxx>
  • Date: Wed, 02 Jul 2014 13:11:02 +0000
  • Delivery-date: Wed, 02 Jul 2014 13:11:14 +0000
  • List-id: "Change log for Mercurial \(receive only\)" <xen-changelog.lists.xen.org>

# HG changeset patch
# User Juergen Gross <jgross@xxxxxxxx>
# Date 1404305784 -7200
# Node ID 0a5bb80edc458252c0150fbe58c286cf83ad9580
# Parent  0251893a7d5a99e7574e7fd645cc126b2f641103
scsiback: correct grant page unmapping

In function scsiback_fast_flush_area() the unmap array is set up with sparse
entries in case of some grant pages could not be mapped originally. This can
lead to never unmapped grant pages.

The unmap array is to be indexed with the so far found number of valid grants,
not with the loop variable.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Committed-by: Jan Beulich <jbeulich@xxxxxxxx>
---


diff -r 0251893a7d5a -r 0a5bb80edc45 drivers/xen/scsiback/scsiback.c
--- a/drivers/xen/scsiback/scsiback.c   Mon Jun 16 16:11:33 2014 +0200
+++ b/drivers/xen/scsiback/scsiback.c   Wed Jul 02 14:56:24 2014 +0200
@@ -92,7 +92,7 @@ void scsiback_fast_flush_area(pending_re
                        handle = pending_handle(req, i);
                        if (handle == SCSIBACK_INVALID_HANDLE)
                                continue;
-                       gnttab_set_unmap_op(&unmap[i], vaddr(req, i),
+                       gnttab_set_unmap_op(&unmap[invcount], vaddr(req, i),
                                                GNTMAP_host_map, handle);
                        pending_handle(req, i) = SCSIBACK_INVALID_HANDLE;
                        invcount++;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.