[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] xen: arm: correct off-by-one error in consider_modules
commit dea3ff6ed2af2fe3ab084733d3e71daf4dcfb8a0 Author: Ian Campbell <ijc@xxxxxxxxxxxxxx> AuthorDate: Sun Dec 21 11:18:53 2014 +0000 Commit: Ian Campbell <ian.campbell@xxxxxxxxxx> CommitDate: Tue Jan 6 11:12:19 2015 +0000 xen: arm: correct off-by-one error in consider_modules By iterating up to <= mi->nr_mods we are running off the end of the boot modules, but more importantly it causes us to then skip the first FDT reserved region, meaning we might clobber it. Signed-off-by: Ian Campbell <ijc@xxxxxxxxxxxxxx> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx> --- xen/arch/arm/setup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3991d64..f49569d 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -286,7 +286,7 @@ static paddr_t __init consider_modules(paddr_t s, paddr_t e, return 0; /* First check the boot modules */ - for ( i = first_mod; i <= mi->nr_mods; i++ ) + for ( i = first_mod; i < mi->nr_mods; i++ ) { paddr_t mod_s = mi->module[i].start; paddr_t mod_e = mod_s + mi->module[i].size; -- generated by git-patchbot for /home/xen/git/xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |