[Xen-changelog] [xen master] tools/libxl: Correct static pattern rule for pkgconfig files

[patchbot@xxxxxxx]

commit 027af8cdb348a97478a177d13871cacaa9b03366
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Tue Jan 27 20:34:02 2015 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Wed Jan 28 09:59:46 2015 +0000

    tools/libxl: Correct static pattern rule for pkgconfig files
    
    Attempting to build libxl causes Make to emit the following warnings
    
    andrewcoop@andrewcoop:xen.git$ make -C tools/libxl all
    ...
    Makefile:253: target `xenlight.pc' doesn't match the target pattern
    Makefile:253: target `xlutil.pc' doesn't match the target pattern
    ...
    
    because the static pattern rule is malformed.  'Makefile' as the only
    prereq-pattern does not contain a pattern.
    
    The rule ends up working because of the use of $@.in where $< should have 
been
    used, but lacked any dependency between a $FOO.pc and its .in source file.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
    CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
    CC: Wei Liu <wei.liu2@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 tools/libxl/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 5df4970..7329521 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -250,8 +250,8 @@ libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so
 testidl: testidl.o libxlutil.so libxenlight.so
        $(CC) $(LDFLAGS) -o $@ testidl.o libxlutil.so $(LDLIBS_libxenlight) 
$(LDLIBS_libxenctrl) $(APPEND_LDFLAGS)
 
-$(PKG_CONFIG): %.in : Makefile
-       @sed -e 's/@@version@@/$(MAJOR).$(MINOR)/g' < $@.in > $@.new
+$(PKG_CONFIG): % : %.in Makefile
+       @sed -e 's/@@version@@/$(MAJOR).$(MINOR)/g' < $< > $@.new
        @mv -f $@.new $@
 
 .PHONY: install
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog