[Xen-changelog] [linux-2.6.18-xen] sfc_netfront: deal with gcc5 warning

[Xen patchbot-linux-2.6.18-xen <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1425635649 -3600
# Node ID 29dd60ae4773da716d26260e19743081c1dd162a
# Parent  a3e3a5aea1a2aa30d7f45d9f69569bb3c7ca20e7
sfc_netfront: deal with gcc5 warning

gcc5 warns about (!x == y) assuming !(x == y) may be meant, and the
driver's Makefile enforcing -Werror results in this failing the build.
As the construct looks bogus anyway (making it harder to grok than
necessary) fix it here (there's a second one which isn't being fixed,
as gcc is being or already was changed to not warn on (!!a == b) and
alike).

Reported-by: Jiri Slaby <jslaby@xxxxxxx>
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---


diff -r a3e3a5aea1a2 -r 29dd60ae4773 drivers/xen/sfc_netfront/falcon_event.c
--- a/drivers/xen/sfc_netfront/falcon_event.c   Mon Feb 02 09:09:54 2015 +0100
+++ b/drivers/xen/sfc_netfront/falcon_event.c   Fri Mar 06 10:54:09 2015 +0100
@@ -110,7 +110,7 @@ ef_vi_inline int falcon_rx_check_dup(ef_
 #endif
        BUG_ON(!QWORD_TEST_BIT(RX_EV_FRM_TRUNC, *ev));
        BUG_ON( QWORD_TEST_BIT(RX_EV_PKT_OK, *ev));
-       BUG_ON(!QWORD_GET_U(RX_EV_BYTE_CNT, *ev) == 0);
+       BUG_ON(QWORD_GET_U(RX_EV_BYTE_CNT, *ev));
        ev_out->rx_no_desc_trunc.type = EF_EVENT_TYPE_RX_NO_DESC_TRUNC;
        ev_out->rx_no_desc_trunc.q_id = q_id;
        return 1;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog