[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] xen/arm: timer: Don't warn if the timer interrupts are high-level



commit d4b67cfd8433fa5c515fe9134737c1348758a222
Author:     Julien Grall <julien.grall@xxxxxxxxxx>
AuthorDate: Mon Mar 2 15:54:57 2015 +0000
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Mon Mar 2 17:02:12 2015 +0000

    xen/arm: timer: Don't warn if the timer interrupts are high-level
    
    The commit 61d6a84 "xen: arm: Warn if timer interrupts are not level
    triggered" added a check to ensure the timer interrupts are level.
    
    Although, the check is only done on low-level interrupts. This will
    result to a strange warning on platform using high-level ("WARNING [..]
    IRQ is not level triggered").
    
    As high-level interrupt is valid, don't warn on both high-level and
    low-level interrupt.
    
    Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/arch/arm/time.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c
index 8977cce..352e25e 100644
--- a/xen/arch/arm/time.c
+++ b/xen/arch/arm/time.c
@@ -217,7 +217,7 @@ static void check_timer_irq_cfg(unsigned int irq, const 
char *which)
      * The interrupt controller driver will update desc->arch.type with
      * the actual type which ended up configured in the hardware.
      */
-    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW )
+    if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_MASK )
         return;
 
     printk(XENLOG_WARNING
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.