[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] x86/vmx: fix vmx_is_singlestep_supported return value



commit 340ade2f0ef692efce01a708ad98629af985f978
Author:     Tamas K Lengyel <tlengyel@xxxxxxxxxxx>
AuthorDate: Fri Aug 28 12:17:05 2015 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Aug 28 12:17:05 2015 +0200

    x86/vmx: fix vmx_is_singlestep_supported return value
    
    The function supposed to return a boolean but instead it returned
    the value 0x8000000 which is the Intel internal flag for MTF. This has
    caused various checks using this function to falsely report no MTF
    capability.
    
    Signed-off-by: Tamas K Lengyel <tlengyel@xxxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
    Release-acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 xen/arch/x86/hvm/vmx/vmx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
index 999defe..2582cdd 100644
--- a/xen/arch/x86/hvm/vmx/vmx.c
+++ b/xen/arch/x86/hvm/vmx/vmx.c
@@ -1768,7 +1768,7 @@ static void vmx_enable_msr_exit_interception(struct 
domain *d)
 
 static bool_t vmx_is_singlestep_supported(void)
 {
-    return cpu_has_monitor_trap_flag;
+    return !!cpu_has_monitor_trap_flag;
 }
 
 static void vmx_vcpu_update_eptp(struct vcpu *v)
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.