[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] x86/hvm_event: fix uninitialized struct field usage introduced by c/s f5365e6



commit 8e0b74e02656c007455c12d0341a881aee8b13d2
Author:     Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
AuthorDate: Thu Feb 18 15:08:25 2016 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Feb 18 15:09:04 2016 +0100

    x86/hvm_event: fix uninitialized struct field usage introduced by c/s 
f5365e6
    
    c/s f5365e6: "xen/vm-events: Move parts of monitor_domctl code to 
common-side",
    introduced a use without initialization issue.
    hvm_event_breakpoint calls hvm_event_traps(&req) and if sync is true that
    ors some bits into req->flags which was never initialised.
    Reported by Coverity Scan.
    
    Initializes req @ hvm_event_breakpoint entry.
    
    Coverity-ID: 1353192
    Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
    Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/hvm/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/event.c b/xen/arch/x86/hvm/event.c
index 874a36c..cb9c152 100644
--- a/xen/arch/x86/hvm/event.c
+++ b/xen/arch/x86/hvm/event.c
@@ -173,7 +173,7 @@ int hvm_event_breakpoint(unsigned long rip,
 {
     struct vcpu *curr = current;
     struct arch_domain *ad = &curr->domain->arch;
-    vm_event_request_t req;
+    vm_event_request_t req = {};
 
     switch ( type )
     {
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.