[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen stable-4.5] xen/arm: vgic-v2: Report the correct GICC size to the guest



commit 86060f89ad4120a7f8b54bd6bbe055da2c2cf435
Author:     Julien Grall <julien.grall@xxxxxxxxxx>
AuthorDate: Fri Mar 4 13:11:20 2016 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Fri Mar 4 13:11:20 2016 +0100

    xen/arm: vgic-v2: Report the correct GICC size to the guest
    
    The GICv2 DT node is usually used by the guest to know the address/size
    of the regions (GICD, GICC...) to map into their virtual memory.
    
    While the GICv2 spec requires the size of the GICC to be 8KB, we
    correctly do an 8KB stage-2 mapping but erroneously report 256 in the
    device tree (based on GUEST_GICC_SIZE).
    
    I bet we didn't see any issue so far because all the registers except
    GICC_DIR lives in the first 256 bytes of the GICC region and all the
    guests I have seen so far are driving the GIC with GICC_CTLR.EIOmode =
    0.
    
    Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    [ ijc -- fixed some typos in commit message ]
    
    (cherry picked from commit 8ee6d574b7073b5c98fcf94d20a53197609b85e1)
---
 xen/include/public/arch-arm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
index e711606..82766e7 100644
--- a/xen/include/public/arch-arm.h
+++ b/xen/include/public/arch-arm.h
@@ -373,7 +373,7 @@ typedef uint64_t xen_callback_t;
 #define GUEST_GICD_BASE   0x03001000ULL
 #define GUEST_GICD_SIZE   0x00001000ULL
 #define GUEST_GICC_BASE   0x03002000ULL
-#define GUEST_GICC_SIZE   0x00000100ULL
+#define GUEST_GICC_SIZE   0x00002000ULL
 
 /* vGIC v3 mappings */
 #define GUEST_GICV3_GICD_BASE      0x03001000ULL
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.5

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.