[Xen-changelog] [linux-2.6.18-xen] xenbus: inspect the correct type in xenbus_dev_request_and_reply()

[Xen patchbot-linux-2.6.18-xen <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1467966284 -7200
#      Fri Jul 08 10:24:44 2016 +0200
# Node ID 05b894bd0a0fcf83fabfae3f4df6ad3804e1fc52
# Parent  81ed9e7927fb3ef7947cd54207273d5eb072307f
xenbus: inspect the correct type in xenbus_dev_request_and_reply()

Looking at the local variable is wrong for the XS_TRANSACTION_END case:
In case of an earlier error transaction_end() must not be called.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---


diff -r 81ed9e7927fb -r 05b894bd0a0f drivers/xen/xenbus/xenbus_xs.c
--- a/drivers/xen/xenbus/xenbus_xs.c    Wed Jul 06 10:14:48 2016 +0200
+++ b/drivers/xen/xenbus/xenbus_xs.c    Fri Jul 08 10:24:44 2016 +0200
@@ -220,7 +220,7 @@ void *xenbus_dev_request_and_reply(struc
 
        mutex_unlock(&xs_state.request_mutex);
 
-       if ((type == XS_TRANSACTION_END) ||
+       if ((msg->type == XS_TRANSACTION_END) ||
            ((type == XS_TRANSACTION_START) && (msg->type == XS_ERROR)))
                transaction_end();
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog