[Xen-changelog] [xen master] xen/x86: Identify legitimate fallthrough cases

[patchbot@xxxxxxx]

commit e763268781d341fef05d461f3057e6ced5e033f2
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Fri Jul 15 15:36:07 2016 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Mon Jul 18 18:27:06 2016 +0100

    xen/x86: Identify legitimate fallthrough cases
    
    The case in arch_set_info_guest() is a legitimate fallthrough.  Mark it as 
such.
    
    The cases in vlapic_accept_irq() are a terminal error path, but Coverity 
fails
    to spot this.  Reorder the comment to the end.
    
    No functional change, but fixes two MISSING_BREAK Coverity defects.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
---
 xen/arch/x86/domain.c     | 1 +
 xen/arch/x86/hvm/vlapic.c | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
index c8c7e2d..1133ea2 100644
--- a/xen/arch/x86/domain.c
+++ b/xen/arch/x86/domain.c
@@ -1223,6 +1223,7 @@ int arch_set_info_guest(
                 {
                 case -EINTR:
                     rc = -ERESTART;
+                    /* Fallthrough */
                 case -ERESTART:
                     v->arch.old_guest_table =
                         pagetable_get_page(v->arch.guest_table);
diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index e2f4450..ba9b293 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -374,8 +374,7 @@ static void vlapic_accept_irq(struct vcpu *v, uint32_t 
icr_low)
 
     case APIC_DM_INIT:
     case APIC_DM_STARTUP:
-        /* Handled in vlapic_ipi(). */
-        BUG();
+        BUG(); /* Handled in vlapic_ipi(). */
 
     default:
         gdprintk(XENLOG_ERR, "TODO: unsupported delivery mode in ICR %x\n",
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog