[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] pass-through: drop pointless uses of __func__
commit 0d2649370c93a9356f37f50248872e8a0bb5ae40 Author: Jan Beulich <jbeulich@xxxxxxxx> AuthorDate: Mon Aug 29 16:04:22 2016 +0200 Commit: Jan Beulich <jbeulich@xxxxxxxx> CommitDate: Mon Aug 29 16:04:22 2016 +0200 pass-through: drop pointless uses of __func__ Non-debugging message text should be (and is in the cases here) distinguishable without also logging function names. Additionally log the PCI device coordinates for alloc_pdev() failure. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> --- xen/drivers/passthrough/pci.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 8bce213..338d6b4 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -379,8 +379,8 @@ static struct pci_dev *alloc_pdev(struct pci_seg *pseg, u8 bus, u8 devfn) break; default: - printk(XENLOG_WARNING "%s: unknown type: %04x:%02x:%02x.%u\n", - __func__, pseg->nr, bus, PCI_SLOT(devfn), PCI_FUNC(devfn)); + printk(XENLOG_WARNING "%04x:%02x:%02x.%u: unknown type %d\n", + pseg->nr, bus, PCI_SLOT(devfn), PCI_FUNC(devfn), pdev->type); break; } @@ -991,7 +991,8 @@ static int __init _scan_pci_devices(struct pci_seg *pseg, void *arg) pdev = alloc_pdev(pseg, bus, PCI_DEVFN(dev, func)); if ( !pdev ) { - printk("%s: alloc_pdev failed.\n", __func__); + printk(XENLOG_WARNING "%04x:%02x:%02x.%u: alloc_pdev failed\n", + pseg->nr, bus, dev, func); return -ENOMEM; } -- generated by git-patchbot for /home/xen/git/xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx https://lists.xenproject.org/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |