[Xen-changelog] [xen master] xen: credit1: fix mask to be used for tickling in Credit1

[patchbot@xxxxxxx]

commit f83fc393b2bb0a8b97bca07d810684a2c709aaa8
Author:     Dario Faggioli <dario.faggioli@xxxxxxxxxx>
AuthorDate: Thu Sep 15 12:35:03 2016 +0100
Commit:     George Dunlap <george.dunlap@xxxxxxxxxx>
CommitDate: Thu Sep 15 12:39:47 2016 +0100

    xen: credit1: fix mask to be used for tickling in Credit1
    
    If there are idle pcpus inside the waking vcpu's
    soft-affinity mask, we should really tickle one
    of them (this is one of the purposes of the
    __runq_tickle() function itself!), not just
    any idle pcpu.
    
    The issue has been introduced in 02ea5031825d
    ("credit1: properly deal with pCPUs not in any cpupool"),
    where the usage of idle_mask is changed, without
    updating the bottom of the function, where it
    is also referenced.
    
    Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
    Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
---
 xen/common/sched_credit.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c
index 472fb28..16325b5 100644
--- a/xen/common/sched_credit.c
+++ b/xen/common/sched_credit.c
@@ -463,11 +463,12 @@ static inline void __runq_tickle(struct csched_vcpu *new)
                 if ( opt_tickle_one_idle )
                 {
                     this_cpu(last_tickle_cpu) =
-                        cpumask_cycle(this_cpu(last_tickle_cpu), &idle_mask);
+                        cpumask_cycle(this_cpu(last_tickle_cpu),
+                                      cpumask_scratch_cpu(cpu));
                     __cpumask_set_cpu(this_cpu(last_tickle_cpu), &mask);
                 }
                 else
-                    cpumask_or(&mask, &mask, &idle_mask);
+                    cpumask_or(&mask, &mask, cpumask_scratch_cpu(cpu));
             }
 
             /* Did we find anyone? */
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog