[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] x86/emulate: Resolve MISSING_BREAK issue in x86_decode()



commit 933acddf74213f77a5adbb2c10ccd3f72634d456
Author:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
AuthorDate: Fri Sep 30 11:01:04 2016 +0100
Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Fri Sep 30 12:17:01 2016 +0100

    x86/emulate: Resolve MISSING_BREAK issue in x86_decode()
    
    Coverity doesn't appear to be able to spot that this is a terminal error 
path,
    but leave a comment to "fix" MISSING_BREAK.
    
    Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
---
 xen/arch/x86/x86_emulate/x86_emulate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c 
b/xen/arch/x86/x86_emulate/x86_emulate.c
index 78b23a0..32e8b69 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -1891,7 +1891,7 @@ x86_decode(
             switch ( def_ad_bytes )
             {
             default:
-                BUG();
+                BUG(); /* Shouldn't be possible. */
             case 2:
                 if ( in_realmode(ctxt, ops) || (state->regs->eflags & EFLG_VM) 
)
                     break;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.