[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] libxl: fix libxl_set_memory_target



commit ed5f19aea66fe5a72060d6a795ffcd23b7643ee3
Author:     Wei Liu <wei.liu2@xxxxxxxxxx>
AuthorDate: Thu Dec 29 16:36:31 2016 +0000
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Tue Jan 3 11:49:52 2017 +0000

    libxl: fix libxl_set_memory_target
    
    Commit 26dbc93a ("libxl: Remove pointless hypercall from
    libxl_set_memory_target") removed the call to xc_domain_getinfolist, but
    it failed to notice that "info" was actually needed later.
    
    Put that back. While at it, make the code conform to coding style
    requirement.
    
    Reported-by: Juergen Gross <jgross@xxxxxxxx>
    Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/libxl/libxl.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 6fd4fe1..2f83731 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -4308,6 +4308,13 @@ retry_transaction:
     libxl__xs_printf(gc, t, GCSPRINTF("%s/memory/target", dompath),
                      "%"PRIu64, new_target_memkb);
 
+    r = xc_domain_getinfolist(ctx->xch, domid, 1, &info);
+    if (r != 1 || info.domain != domid) {
+        abort_transaction = 1;
+        rc = ERROR_FAIL;
+        goto out;
+    }
+
     libxl_dominfo_init(&ptr);
     xcinfo2xlinfo(ctx, &info, &ptr);
     uuid = libxl__uuid2string(gc, ptr.uuid);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.