[Xen-changelog] [qemu-xen master] io: Add a QIOChannelSocket cleanup test

[patchbot@xxxxxxx]

commit af8096b2c3b16de3f6237f1ead6a657a7565272f
Author:     Felipe Franciosi <felipe@xxxxxxxxxxx>
AuthorDate: Thu Sep 29 08:52:38 2016 -0700
Commit:     Daniel P. Berrange <berrange@xxxxxxxxxx>
CommitDate: Thu Oct 27 09:13:10 2016 +0200

    io: Add a QIOChannelSocket cleanup test
    
    This patch adds a test to verify that the QIOChannel framework will not
    unlink a filesystem unix socket unless the _FEATURE_LISTEN bit is set.
    
    Due to a bug introduced in 74b6ce43, the framework would unlink the
    entry if the _FEATURE_SHUTDOWN bit was set, regardless of the presence
    of _FEATURE_LISTEN.
    
    Signed-off-by: Felipe Franciosi <felipe@xxxxxxxxxxx>
    Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
---
 tests/test-io-channel-socket.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c
index f73e063..aa88c3c 100644
--- a/tests/test-io-channel-socket.c
+++ b/tests/test-io-channel-socket.c
@@ -491,6 +491,37 @@ static void test_io_channel_unix_fd_pass(void)
     }
     g_free(fdrecv);
 }
+
+static void test_io_channel_unix_listen_cleanup(void)
+{
+    QIOChannelSocket *ioc;
+    struct sockaddr_un un;
+    int sock;
+
+#define TEST_SOCKET "test-io-channel-socket.sock"
+
+    ioc = qio_channel_socket_new();
+
+    /* Manually bind ioc without calling the qio api to avoid setting
+     * the LISTEN feature */
+    sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0);
+    memset(&un, 0, sizeof(un));
+    un.sun_family = AF_UNIX;
+    snprintf(un.sun_path, sizeof(un.sun_path), "%s", TEST_SOCKET);
+    unlink(TEST_SOCKET);
+    bind(sock, (struct sockaddr *)&un, sizeof(un));
+    ioc->fd = sock;
+    ioc->localAddrLen = sizeof(ioc->localAddr);
+    getsockname(sock, (struct sockaddr *)&ioc->localAddr,
+                &ioc->localAddrLen);
+
+    g_assert(g_file_test(TEST_SOCKET, G_FILE_TEST_EXISTS));
+    object_unref(OBJECT(ioc));
+    g_assert(g_file_test(TEST_SOCKET, G_FILE_TEST_EXISTS));
+
+    unlink(TEST_SOCKET);
+}
+
 #endif /* _WIN32 */
 
 
@@ -562,6 +593,8 @@ int main(int argc, char **argv)
                     test_io_channel_unix_async);
     g_test_add_func("/io/channel/socket/unix-fd-pass",
                     test_io_channel_unix_fd_pass);
+    g_test_add_func("/io/channel/socket/unix-listen-cleanup",
+                    test_io_channel_unix_listen_cleanup);
 #endif /* _WIN32 */
 
     return g_test_run();
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog