[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] 9pfs: convert 'len/copied_len' field in V9fsXattr to the type of uint64_t



commit 8495f9ad26d398f01e208a53f1a5152483a16084
Author:     Li Qiang <liqiang6-s@xxxxxx>
AuthorDate: Tue Nov 1 12:00:40 2016 +0100
Commit:     Greg Kurz <groug@xxxxxxxx>
CommitDate: Tue Nov 1 12:03:01 2016 +0100

    9pfs: convert 'len/copied_len' field in V9fsXattr to the type of uint64_t
    
    The 'len' in V9fsXattr comes from the 'size' argument in setxattr()
    function in guest. The setxattr() function's declaration is this:
    
    int setxattr(const char *path, const char *name,
                 const void *value, size_t size, int flags);
    
    and 'size' is treated as u64 in linux kernel client code:
    
    int p9_client_xattrcreate(struct p9_fid *fid, const char *name,
                              u64 attr_size, int flags)
    
    So the 'len' should have an type of 'uint64_t'.
    The 'copied_len' in V9fsXattr is used to account for copied bytes, it
    should also have an type of 'uint64_t'.
    
    Suggested-by: Greg Kurz <groug@xxxxxxxx>
    Signed-off-by: Li Qiang <liqiang6-s@xxxxxx>
    Reviewed-by: Greg Kurz <groug@xxxxxxxx>
    Signed-off-by: Greg Kurz <groug@xxxxxxxx>
---
 hw/9pfs/9p.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/9pfs/9p.h b/hw/9pfs/9p.h
index 48065cc..3976b7f 100644
--- a/hw/9pfs/9p.h
+++ b/hw/9pfs/9p.h
@@ -159,8 +159,8 @@ typedef struct V9fsConf
 
 typedef struct V9fsXattr
 {
-    int64_t copied_len;
-    int64_t len;
+    uint64_t copied_len;
+    uint64_t len;
     void *value;
     V9fsString name;
     int flags;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.