[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] 9pfs: drop excessive error message from virtfs_reset()



commit 79decce35b4d769fa878b048ab1a7b3e9045c9c6
Author:     Greg Kurz <groug@xxxxxxxx>
AuthorDate: Tue Nov 1 12:00:40 2016 +0100
Commit:     Greg Kurz <groug@xxxxxxxx>
CommitDate: Tue Nov 1 12:03:03 2016 +0100

    9pfs: drop excessive error message from virtfs_reset()
    
    The virtfs_reset() function is called either when the virtio-9p device
    gets reset, or when the client starts a new 9P session. In both cases,
    if it finds fids from a previous session, the following is printed in
    the monitor:
    
    9pfs:virtfs_reset: One or more uncluncked fids found during reset
    
    For example, if a linux guest with a mounted 9P share is reset from the
    monitor with system_reset, the message will be printed. This is excessive
    since these fids are now clunked and the state is clean.
    
    Signed-off-by: Greg Kurz <groug@xxxxxxxx>
    Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>
---
 hw/9pfs/9p.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index 1050b89..aea7e9d 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -535,7 +535,7 @@ static int coroutine_fn v9fs_mark_fids_unreclaim(V9fsPDU 
*pdu, V9fsPath *path)
 static void coroutine_fn virtfs_reset(V9fsPDU *pdu)
 {
     V9fsState *s = pdu->s;
-    V9fsFidState *fidp = NULL;
+    V9fsFidState *fidp;
 
     /* Free all fids */
     while (s->fid_list) {
@@ -548,11 +548,6 @@ static void coroutine_fn virtfs_reset(V9fsPDU *pdu)
             free_fid(pdu, fidp);
         }
     }
-    if (fidp) {
-        /* One or more unclunked fids found... */
-        error_report("9pfs:%s: One or more uncluncked fids "
-                     "found during reset", __func__);
-    }
 }
 
 #define P9_QID_TYPE_DIR         0x80
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.