[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [qemu-xen master] block: Turn on "unmap" in active commit
commit 6f13acf97efb8aade2ff7e0444c15512f9e65812 Author: Fam Zheng <famz@xxxxxxxxxx> AuthorDate: Tue Sep 27 19:14:52 2016 +0800 Commit: Jeff Cody <jcody@xxxxxxxxxx> CommitDate: Tue Nov 1 07:55:57 2016 -0400 block: Turn on "unmap" in active commit We already specified BDRV_O_UNMAP when opening images in 'qemu-img commit', but didn't turn on the "unmap" in the active commit job. This patch fixes that so that zeroed clusters in top image can be discarded which is desired in the virt-sparsify use case, where a temporary overlay is created and fstrim'ed before commiting back, to free space in the original image. This also enables it for block-commit. Signed-off-by: Fam Zheng <famz@xxxxxxxxxx> Reviewed-by: Eric Blake <eblake@xxxxxxxxxx> Message-id: 1474974892-5031-1-git-send-email-famz@xxxxxxxxxx Signed-off-by: Jeff Cody <jcody@xxxxxxxxxx> --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/mirror.c b/block/mirror.c index 7e99f3a..82a9529 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1081,7 +1081,7 @@ void commit_active_start(const char *job_id, BlockDriverState *bs, mirror_start_job(job_id, bs, base, NULL, speed, 0, 0, MIRROR_LEAVE_BACKING_CHAIN, - on_error, on_error, false, cb, opaque, &local_err, + on_error, on_error, true, cb, opaque, &local_err, &commit_active_job_driver, false, base, auto_complete); if (local_err) { error_propagate(errp, local_err); -- generated by git-patchbot for /home/xen/git/qemu-xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx https://lists.xenproject.org/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |