[Xen-changelog] [qemu-xen master] hmp: Make block_stream set an explicit job ID

[patchbot@xxxxxxx]

commit 11d6fbe05fd67610a7735e5350e4299f93bf7655
Author:     Alberto Garcia <berto@xxxxxxxxxx>
AuthorDate: Fri Nov 4 15:44:43 2016 +0200
Commit:     Kevin Wolf <kwolf@xxxxxxxxxx>
CommitDate: Fri Nov 11 15:54:55 2016 +0100

    hmp: Make block_stream set an explicit job ID
    
    A job ID is always required in order to create a block job on a
    non-root node. The default ID (obtained with bdrv_get_device_name())
    is otherwise empty in this scenario and the job cannot be created.
    
    The HMP block_stream command doesn't set a job ID and therefore it
    doesn't allow streaming to intermediate nodes. One solution is to add
    an extra parameter to set a job ID. The other solution is to simply
    use the node name passed to block_stream as job ID. This won't work
    if it's automatically generated (because it contains a '#') but is
    otherwise simple enough for all other cases.
    
    This way 'block_stream node3' will create a job with the ID 'node3'
    and the good old 'block_stream virtio0' will keep the previous
    behaviour and use 'virtio0' for the job ID.
    
    Signed-off-by: Alberto Garcia <berto@xxxxxxxxxx>
    Signed-off-by: Kevin Wolf <kwolf@xxxxxxxxxx>
---
 hmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hmp.c b/hmp.c
index b5e3f54..819166d 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1570,7 +1570,7 @@ void hmp_block_stream(Monitor *mon, const QDict *qdict)
     const char *base = qdict_get_try_str(qdict, "base");
     int64_t speed = qdict_get_try_int(qdict, "speed", 0);
 
-    qmp_block_stream(false, NULL, device, base != NULL, base, false, NULL,
+    qmp_block_stream(true, device, device, base != NULL, base, false, NULL,
                      false, NULL, qdict_haskey(qdict, "speed"), speed,
                      true, BLOCKDEV_ON_ERROR_REPORT, &error);
 
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog