[Xen-changelog] [qemu-xen master] powernv: CPU compatibility modes don't make sense for powernv

[patchbot@xxxxxxx]

commit 8bd9530e1302566e9dc71abe04346ca7d16613b1
Author:     David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
AuthorDate: Tue Nov 1 10:25:29 2016 +1100
Commit:     David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
CommitDate: Tue Nov 15 10:05:51 2016 +1100

    powernv: CPU compatibility modes don't make sense for powernv
    
    powernv has some code (derived from the spapr equivalent) used in device
    tree generation which depends on the CPU's compatibility mode / logical
    PVR.  However, compatibility modes don't make sense on powernv - at least
    not as a property controlled by the host - because the guest in powernv
    has full hypervisor level access to the virtual system, and so owns the
    PCR (Processor Compatibility Register) which implements compatiblity modes.
    
    Note: the new logic doesn't take into account kvmppc_smt_threads() like the
    old version did.  However, if core->nr_threads exceeds kvmppc_smt_threads()
    then things will already be broken and clamping the value in the device
    tree isn't going to save us.
    
    Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
    Reviewed-by: Greg Kurz <groug@xxxxxxxx>
    Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx>
---
 hw/ppc/pnv.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 82276e0..6af3424 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -110,7 +110,7 @@ static void powernv_create_core_node(PnvChip *chip, PnvCore 
*pc, void *fdt)
     CPUState *cs = CPU(DEVICE(pc->threads));
     DeviceClass *dc = DEVICE_GET_CLASS(cs);
     PowerPCCPU *cpu = POWERPC_CPU(cs);
-    int smt_threads = ppc_get_compat_smt_threads(cpu);
+    int smt_threads = CPU_CORE(pc)->nr_threads;
     CPUPPCState *env = &cpu->env;
     PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cs);
     uint32_t servers_prop[smt_threads];
@@ -206,10 +206,6 @@ static void powernv_create_core_node(PnvChip *chip, 
PnvCore *pc, void *fdt)
     _FDT((fdt_setprop(fdt, offset, "ibm,pa-features",
                        pa_features, sizeof(pa_features))));
 
-    if (cpu->cpu_version) {
-        _FDT((fdt_setprop_cell(fdt, offset, "cpu-version", cpu->cpu_version)));
-    }
-
     /* Build interrupt servers properties */
     for (i = 0; i < smt_threads; i++) {
         servers_prop[i] = cpu_to_be32(pc->pir + i);
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog