[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] net: skip virtio-net config of deleted nic's peers



commit 68b5f314a269979b4f2014eb22873732d4745bcc
Author:     Yuri Benditovich <yuri.benditovich@xxxxxxxxxx>
AuthorDate: Tue Nov 1 00:01:17 2016 +0200
Commit:     Jason Wang <jasowang@xxxxxxxxxx>
CommitDate: Tue Nov 15 15:36:21 2016 +0800

    net: skip virtio-net config of deleted nic's peers
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1373816
    qemu core dump happens during repetitive unpug-plug
    with multiple queues and Windows RSS-capable guest.
    If back-end delete requested during virtio-net device
    initialization, driver still can try configure the device
    for multiple queues. The virtio-net device is expected
    to be removed as soon as the initialization is done.
    
    Signed-off-by: Yuri Benditovich <yuri.benditovich@xxxxxxxxxx>
    Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
---
 hw/net/virtio-net.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 06bfe4b..77a4fae 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -508,6 +508,10 @@ static void virtio_net_set_queues(VirtIONet *n)
     int i;
     int r;
 
+    if (n->nic->peer_deleted) {
+        return;
+    }
+
     for (i = 0; i < n->max_queues; i++) {
         if (i < n->curr_queues) {
             r = peer_attach(n, i);
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.