[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] net: mcf: check receive buffer size register value



commit 77d54985b85a0cb760330ec2bd92505e0a2a97a9
Author:     Prasad J Pandit <pjp@xxxxxxxxxxxxxxxxx>
AuthorDate: Tue Nov 29 00:38:39 2016 +0530
Commit:     Jason Wang <jasowang@xxxxxxxxxx>
CommitDate: Mon Dec 5 17:45:14 2016 +0800

    net: mcf: check receive buffer size register value
    
    ColdFire Fast Ethernet Controller uses a receive buffer size
    register(EMRBR) to hold maximum size of all receive buffers.
    It is set by a user before any operation. If it was set to be
    zero, ColdFire emulator would go into an infinite loop while
    receiving data in mcf_fec_receive. Add check to avoid it.
    
    Reported-by: Wjjzhang <wjjzhang@xxxxxxxxxxx>
    Signed-off-by: Prasad J Pandit <pjp@xxxxxxxxxxxxxxxxx>
    Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
---
 hw/net/mcf_fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/mcf_fec.c b/hw/net/mcf_fec.c
index dc61bac..4025eb3 100644
--- a/hw/net/mcf_fec.c
+++ b/hw/net/mcf_fec.c
@@ -393,7 +393,7 @@ static void mcf_fec_write(void *opaque, hwaddr addr,
         s->tx_descriptor = s->etdsr;
         break;
     case 0x188:
-        s->emrbr = value & 0x7f0;
+        s->emrbr = value > 0 ? value & 0x7F0 : 0x7F0;
         break;
     default:
         hw_error("mcf_fec_write Bad address 0x%x\n", (int)addr);
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.