[Xen-changelog] [xen stable-4.5] oxenstored: track commit history

[patchbot@xxxxxxx]

commit 62ef9b297ee7d8739b7d90796858151ee832ff97
Author:     Jonathan Davies <jonathan.davies@xxxxxxxxxx>
AuthorDate: Mon Mar 27 08:58:29 2017 +0000
Commit:     Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
CommitDate: Wed Apr 5 15:22:33 2017 +0100

    oxenstored: track commit history
    
    Since the list of historic activity cannot grow without bound, it is safe 
to use
    this to track commits.
    
    Reported-by: Juergen Gross <jgross@xxxxxxxx>
    Signed-off-by: Jonathan Davies <jonathan.davies@xxxxxxxxxx>
    Reviewed-by: Thomas Sanders <thomas.sanders@xxxxxxxxxx>
---
 tools/ocaml/xenstored/process.ml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml
index 9d085fb..4d757fc 100644
--- a/tools/ocaml/xenstored/process.ml
+++ b/tools/ocaml/xenstored/process.ml
@@ -290,12 +290,7 @@ let write_response_log ~ty ~tid ~con ~response =
 let record_commit ~con ~tid ~before ~after =
        let inc r = r := Int64.add 1L !r in
        let finish_count = inc Transaction.counter; !Transaction.counter in
-       (* This call would leak memory if historic activity is retained forever
-          so can only be uncommented if history is guaranteed not to grow
-          unboundedly.
        History.push {History.con=con; tid=tid; before=before; after=after; 
finish_count=finish_count}
-       *)
-       ()
 
 (* Replay a stored transaction against a fresh store, check the responses are
    all equivalent: if so, commit the transaction. Otherwise send the abort to
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.5

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog