[Xen-changelog] [xen master] memory: don't hand MFN info to translated guests

[patchbot@xxxxxxx]

commit d18627583df28facd9af473ea1ac4a56e93e6ea9
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Apr 5 16:39:53 2017 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Apr 5 16:39:53 2017 +0200

    memory: don't hand MFN info to translated guests
    
    We shouldn't hand MFN info back from increase-reservation for
    translated domains, just like we don't for populate-physmap and
    memory-exchange. For full symmetry also check for a NULL guest handle
    in populate_physmap() (but note this makes no sense in
    memory_exchange(), as there the array is also an input).
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Released-acked-by: Julien Grall <julien.grall@xxxxxxx>
---
 xen/common/memory.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/common/memory.c b/xen/common/memory.c
index bed43e2..52879e7 100644
--- a/xen/common/memory.c
+++ b/xen/common/memory.c
@@ -122,7 +122,8 @@ static void increase_reservation(struct memop_args *a)
         }
 
         /* Inform the domain of the new page's machine address. */ 
-        if ( !guest_handle_is_null(a->extent_list) )
+        if ( !paging_mode_translate(d) &&
+             !guest_handle_is_null(a->extent_list) )
         {
             mfn = page_to_mfn(page);
             if ( unlikely(__copy_to_guest_offset(a->extent_list, i, &mfn, 1)) )
@@ -238,7 +239,8 @@ static void populate_physmap(struct memop_args *a)
 
             guest_physmap_add_page(d, _gfn(gpfn), _mfn(mfn), a->extent_order);
 
-            if ( !paging_mode_translate(d) )
+            if ( !paging_mode_translate(d) &&
+                 !guest_handle_is_null(a->extent_list) )
             {
                 for ( j = 0; j < (1U << a->extent_order); j++ )
                     set_gpfn_from_mfn(mfn + j, gpfn + j);
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog