[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] x86/vIO-APIC: fix uninitialized variable warning



commit 7a481bfa4f6a623e87a4bac3b50a5ef5924d9f2c
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Thu Apr 13 17:35:02 2017 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Thu Apr 13 17:35:02 2017 +0200

    x86/vIO-APIC: fix uninitialized variable warning
    
    In a release build modern gcc validly complains about "pin" possibly
    being uninitialized in vioapic_irq_positive_edge().
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Release-acked-by: Julien Grall <julien.grall@xxxxxxx>
---
 xen/arch/x86/hvm/vioapic.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/arch/x86/hvm/vioapic.c b/xen/arch/x86/hvm/vioapic.c
index 52555cd..5157db7 100644
--- a/xen/arch/x86/hvm/vioapic.c
+++ b/xen/arch/x86/hvm/vioapic.c
@@ -421,7 +421,11 @@ void vioapic_irq_positive_edge(struct domain *d, unsigned 
int irq)
     struct hvm_vioapic *vioapic = gsi_vioapic(d, irq, &pin);
     union vioapic_redir_entry *ent;
 
-    ASSERT(vioapic);
+    if ( !vioapic )
+    {
+        ASSERT_UNREACHABLE();
+        return;
+    }
 
     HVM_DBG_LOG(DBG_LEVEL_IOAPIC, "irq %x", irq);
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.