[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] arm: p2m: Prevent redundant icache flushes



commit 1a0c3e3e28d6cd072734990efcaaec608bf152b1
Author:     Punit Agrawal <punit.agrawal@xxxxxxx>
AuthorDate: Fri May 26 12:14:06 2017 +0100
Commit:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
CommitDate: Tue Jun 6 11:49:26 2017 -0700

    arm: p2m: Prevent redundant icache flushes
    
    When toolstack requests flushing the caches, flush_page_to_ram() is
    called for each page of the requested domain. This needs to unnecessary
    icache invalidation operations.
    
    Let's take the responsibility of performing icache operations and use
    the recently introduced flag to prevent redundant icache operations by
    flush_page_to_ram().
    
    Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
---
 xen/arch/arm/p2m.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 2919989..b7bbea1 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1398,13 +1398,15 @@ int p2m_cache_flush(struct domain *d, gfn_t start, 
unsigned long nr)
         /* XXX: Implement preemption */
         while ( gfn_x(start) < gfn_x(next_gfn) )
         {
-            flush_page_to_ram(mfn_x(mfn), true);
+            flush_page_to_ram(mfn_x(mfn), false);
 
             start = gfn_add(start, 1);
             mfn = mfn_add(mfn, 1);
         }
     }
 
+    invalidate_icache();
+
     p2m_read_unlock(p2m);
 
     return 0;
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.