[Xen-changelog] [xen stable-4.8] xen/arm: Fix the issue in cmp_mmio_handler used in find_mmio_handler

[patchbot@xxxxxxx]

commit 667f70e658c4c382672056ebaf1505b4c5cdb0aa
Author:     Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
AuthorDate: Fri Sep 29 11:29:46 2017 +0530
Commit:     Stefano Stabellini <sstabellini@xxxxxxxxxx>
CommitDate: Fri Oct 6 17:46:18 2017 -0700

    xen/arm: Fix the issue in cmp_mmio_handler used in find_mmio_handler
    
    This patch fixes the wrong range check done in cmp_mmio_handler().
    
    This function returns -1 , 0 or 1  based on whether the key value
    is below the range, in the range or above the range where the range is
    (start, start+size). However, it should check against (start, start+size-1)
    because start+size falls outside the range.
    
    This resulted in returning a wrong mmio_handler for a given mmio address 
which
    happened to be start+size.
    
    This bug was introduced when the mmio region search switched from
    linear search to binary search in the following commit:
    
    8047e09 "xen/arm: io: Use binary search for mmio handler lookup".
    
    Signed-off-by: Bhupinder Thakur <bhupinder.thakur@xxxxxxxxxx>
    Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
    (cherry picked from commit b7ed331353a14f43f53eaf6a3a543ec8385193a3)
---
 xen/arch/arm/io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/io.c b/xen/arch/arm/io.c
index e8aa7fa..8dd1928 100644
--- a/xen/arch/arm/io.c
+++ b/xen/arch/arm/io.c
@@ -80,7 +80,7 @@ static int cmp_mmio_handler(const void *key, const void *elem)
     if ( handler0->addr < handler1->addr )
         return -1;
 
-    if ( handler0->addr > (handler1->addr + handler1->size) )
+    if ( handler0->addr >= (handler1->addr + handler1->size) )
         return 1;
 
     return 0;
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.8

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog