[Xen-changelog] [qemu-xen master] arm_gicv3_kvm: Fix compile warning

[patchbot@xxxxxxx]

commit 85cdc23e755f1f65a1820fb68a8ed91c1f7b3a1f
Author:     Pranith Kumar <bobby.prani@xxxxxxxxx>
AuthorDate: Mon Sep 4 15:21:56 2017 +0100
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Thu Sep 14 19:24:05 2017 -0500

    arm_gicv3_kvm: Fix compile warning
    
    Fix the following warning:
    
    /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is 
only applied to the left hand side of this bitwise operator 
[-Wlogical-not-parentheses]
                if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                    ^             ~
    /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses 
after the '!' to evaluate the bitwise operator first
                if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                    ^
    /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: note: add parentheses 
around left hand side expression to silence this warning
                if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
                    ^
    
    This logic error meant we were not setting the PTZ
    bit when we should -- luckily as the comment suggests
    this wouldn't have had any effects beyond making GIC
    initialization take a little longer.
    
    Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
    Message-id: 20170829173226.7625-1-bobby.prani@xxxxxxxxx
    Cc: qemu-stable@xxxxxxxxxx
    Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
    Signed-off-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
    (cherry picked from commit 7229ec5825df6b933f150b54a8a2bedd2de1864c)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/intc/arm_gicv3_kvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
index 6051c77..481fe54 100644
--- a/hw/intc/arm_gicv3_kvm.c
+++ b/hw/intc/arm_gicv3_kvm.c
@@ -293,7 +293,7 @@ static void kvm_arm_gicv3_put(GICv3State *s)
             kvm_gicr_access(s, GICR_PROPBASER + 4, ncpu, &regh, true);
 
             reg64 = c->gicr_pendbaser;
-            if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) {
+            if (!(c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS)) {
                 /* Setting PTZ is advised if LPIs are disabled, to reduce
                  * GIC initialization time.
                  */
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog