[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [qemu-xen master] s390x/ipl: The s390-ipl device is not hot-pluggable



commit 8a9d7f30636b5ab151f47c7f03b4797bc1408151
Author:     Thomas Huth <thuth@xxxxxxxxxx>
AuthorDate: Wed Aug 16 07:30:58 2017 +0200
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Fri Sep 22 18:12:09 2017 -0500

    s390x/ipl: The s390-ipl device is not hot-pluggable
    
    The s390-ipl device can not be created by the user, since it is meant only
    to  be instantiated once internally to load the ROMs and kernel. If the user
    tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with
    a "ROM images must be loaded at startup" error message.
    
    Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
    Message-Id: <1502861458-30270-1-git-send-email-thuth@xxxxxxxxxx>
    Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
    Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx>
    (cherry picked from commit 0d4fa4996fc5ee56ea7d072e272b8e69948460a5)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/s390x/ipl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index cc36003..0d06fc1 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void 
*data)
     dc->reset = s390_ipl_reset;
     dc->vmsd = &vmstate_ipl;
     set_bit(DEVICE_CATEGORY_MISC, dc->categories);
+    /* Reason: Loads the ROMs and thus can only be used one time - internally 
*/
+    dc->user_creatable = false;
 }
 
 static const TypeInfo s390_ipl_info = {
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.