[Xen-changelog] [qemu-xen master] hw/arm/aspeed_soc: Mark devices as user_creatable = false

[patchbot@xxxxxxx]

commit cc7dd3ad3fce9baf0e869847a6ddef33f2b463ab
Author:     Thomas Huth <thuth@xxxxxxxxxx>
AuthorDate: Mon Sep 4 15:21:55 2017 +0100
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Fri Sep 22 18:12:31 2017 -0500

    hw/arm/aspeed_soc: Mark devices as user_creatable = false
    
    QEMU currently aborts if the user is accidentially trying to
    do something like this:
    
    $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
    QEMU 2.9.93 monitor - type 'help' for more information
    (qemu) device_add ast2400
    Unexpected error in error_set_from_qdev_prop_error()
     at hw/core/qdev-properties.c:1032:
    Aborted (core dumped)
    
    The ast2400 SoC devices are clearly not creatable by the user since
    they are using the serial_hds and nd_table arrays directly in their
    realize function, so mark them with user_creatable = false.
    
    Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx>
    Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
    Reviewed-by: Cédric Le Goater <clg@xxxxxxxx>
    Signed-off-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
    (cherry picked from commit 469f3da42ef4af347fa7831e1cc0bd35d17f5b83)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/arm/aspeed_soc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
index 5529024..7f1be04 100644
--- a/hw/arm/aspeed_soc.c
+++ b/hw/arm/aspeed_soc.c
@@ -338,6 +338,8 @@ static void aspeed_soc_class_init(ObjectClass *oc, void 
*data)
 
     sc->info = (AspeedSoCInfo *) data;
     dc->realize = aspeed_soc_realize;
+    /* Reason: Uses serial_hds and nd_table in realize() directly */
+    dc->user_creatable = false;
 }
 
 static const TypeInfo aspeed_soc_type_info = {
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog