[Xen-changelog] [xen master] x86/microcode: Propagate microcode update errors

[patchbot@xxxxxxx]

commit 24882b38d640ff5260742bdb1f88bc92b4039392
Author:     Uwe Dannowski <uwed@xxxxxxxxx>
AuthorDate: Fri Feb 16 13:19:54 2018 +0000
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Feb 16 13:33:13 2018 +0000

    x86/microcode: Propagate microcode update errors
    
    Errors on updating the microcode in the processor were silently
    dropped when invoked via the microcode_update hypercall. Also, the log
    message was misleading.
    
    Signed-off-by: Uwe Dannowski <uwed@xxxxxxxxx>
    Reviewed-by: Stefan Nuernberger <snu@xxxxxxxxx>
    Reviewed-by: Martin Pohlack <mpohlack@xxxxxxxxx>
    Reviewed-by: Amit Shah <aams@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/arch/x86/microcode_intel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/microcode_intel.c b/xen/arch/x86/microcode_intel.c
index c6b67e4..9657575 100644
--- a/xen/arch/x86/microcode_intel.c
+++ b/xen/arch/x86/microcode_intel.c
@@ -309,7 +309,8 @@ static int apply_microcode(unsigned int cpu)
     if ( val[1] != uci->mc.mc_intel->hdr.rev )
     {
         printk(KERN_ERR "microcode: CPU%d update from revision "
-               "%#x to %#x failed\n", cpu_num, uci->cpu_sig.rev, val[1]);
+               "%#x to %#x failed. Resulting revision is %#x.\n", cpu_num,
+               uci->cpu_sig.rev, uci->mc.mc_intel->hdr.rev, val[1]);
         return -EIO;
     }
     printk(KERN_INFO "microcode: CPU%d updated from revision "
@@ -387,7 +388,7 @@ static int cpu_request_microcode(unsigned int cpu, const 
void *buf,
         error = offset;
 
     if ( !error && matching_count )
-        apply_microcode(cpu);
+        error = apply_microcode(cpu);
 
     return error;
 }
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog