[Xen-changelog] [qemu-xen master] spapr: add missing break in h_get_cpu_characteristics()

[patchbot@xxxxxxx]

commit 00e9fba2beb4a0366965ce4ec1068df68ce9f4c0
Author:     Greg Kurz <groug@xxxxxxxx>
AuthorDate: Thu Feb 1 20:47:41 2018 +0100
Commit:     Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
CommitDate: Mon Feb 12 19:39:27 2018 -0600

    spapr: add missing break in h_get_cpu_characteristics()
    
    Detected by Coverity (CID 1385702). This fixes the recently added hypercall
    to let guests properly apply Spectre and Meltdown workarounds.
    
    Fixes: c59704b25473 "target/ppc/spapr: Add H-Call H_GET_CPU_CHARACTERISTICS"
    Reported-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
    Signed-off-by: Greg Kurz <groug@xxxxxxxx>
    Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@xxxxxxxxx>
    Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
    (cherry picked from commit fa86f59234919b479b7e8da6b0dc2dad894a5eac)
    Signed-off-by: Michael Roth <mdroth@xxxxxxxxxxxxxxxxxx>
---
 hw/ppc/spapr_hcall.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
index 0e1a0ae..8416452 100644
--- a/hw/ppc/spapr_hcall.c
+++ b/hw/ppc/spapr_hcall.c
@@ -1698,6 +1698,7 @@ static target_ulong h_get_cpu_characteristics(PowerPCCPU 
*cpu,
     switch (safe_indirect_branch) {
     case SPAPR_CAP_FIXED:
         characteristics |= H_CPU_CHAR_BCCTRL_SERIALISED;
+        break;
     default: /* broken */
         assert(safe_indirect_branch == SPAPR_CAP_BROKEN);
         break;
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog