[Xen-changelog] [xen master] tools/xenstore: fix linking libxenstore with ldl

[patchbot@xxxxxxx]

commit 1a373194922bc73ab4113eb4d5550e5dc922782b
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Fri Mar 23 08:42:53 2018 +0100
Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Fri Mar 23 16:27:42 2018 +0000

    tools/xenstore: fix linking libxenstore with ldl
    
    Commit 448c03b3cbe1487 ("tools/xenstore: try to get minimum thread
    stack size for watch thread") added a dependency to libdl to
    libxenstore. Unfortunately the way it was added requires now all
    users of libxenstore to specify "-ldl" when linking. This can be
    avoided by linking libxenstore.so specifying "-ldl" as a trailing
    option. So use APPEND_LDFLAGS instead of LDFLAGS for adding the
    "-ldl" option when linking libxenstore.so.
    
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Reviewed-by: Doug Goldstein <cardoe@xxxxxxxxxx>
    Tested-by: Doug Goldstein <cardoe@xxxxxxxxxx>
    Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/xenstore/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstore/Makefile b/tools/xenstore/Makefile
index 69e55e73e5..445e9911b2 100644
--- a/tools/xenstore/Makefile
+++ b/tools/xenstore/Makefile
@@ -104,7 +104,7 @@ libxenstore.so.$(MAJOR): libxenstore.so.$(MAJOR).$(MINOR)
 xs.opic: CFLAGS += -DUSE_PTHREAD
 ifeq ($(CONFIG_Linux),y)
 xs.opic: CFLAGS += -DUSE_DLSYM
-libxenstore.so.$(MAJOR).$(MINOR): LDFLAGS += -ldl
+libxenstore.so.$(MAJOR).$(MINOR): APPEND_LDFLAGS += -ldl
 else
 PKG_CONFIG_REMOVE += -ldl
 endif
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog