[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] libxc: do not return a value from xc_cpuid_policy



commit 9ac1205de1d6052bbb47f0cf8467f1385ac8e9fe
Author:     Roger Pau Monne <roger.pau@xxxxxxxxxx>
AuthorDate: Thu Jun 28 12:12:07 2018 +0200
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Thu Jun 28 11:32:42 2018 +0100

    libxc: do not return a value from xc_cpuid_policy
    
    None of the called functions return any errors, so there's no point in
    returning an int from xc_cpuid_policy.
    
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 tools/libxc/xc_cpuid_x86.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
index 364f802c0f..3d1421aa50 100644
--- a/tools/libxc/xc_cpuid_x86.c
+++ b/tools/libxc/xc_cpuid_x86.c
@@ -592,9 +592,9 @@ static void xc_cpuid_pv_policy(xc_interface *xch,
     }
 }
 
-static int xc_cpuid_policy(xc_interface *xch,
-                           const struct cpuid_domain_info *info,
-                           const unsigned int *input, unsigned int *regs)
+static void xc_cpuid_policy(xc_interface *xch,
+                            const struct cpuid_domain_info *info,
+                            const unsigned int *input, unsigned int *regs)
 {
     /*
      * For hypervisor leaves (0x4000XXXX) only 0x4000xx00.EAX[7:0] bits (max
@@ -604,15 +604,13 @@ static int xc_cpuid_policy(xc_interface *xch,
     if ( (input[0] & 0xffff0000) == 0x40000000 )
     {
         regs[0] = regs[1] = regs[2] = regs[3] = 0;
-        return 0;
+        return;
     }
 
     if ( info->hvm )
         xc_cpuid_hvm_policy(xch, info, input, regs);
     else
         xc_cpuid_pv_policy(xch, info, input, regs);
-
-    return 0;
 }
 
 static int xc_cpuid_do_domctl(
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.