[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] tools/gdbsx: fix build with clang 3.8



commit 1626164929d54dc57a1f43e24f5560f13f2420fe
Author:     Wei Liu <wei.liu2@xxxxxxxxxx>
AuthorDate: Mon Jul 23 11:26:48 2018 +0100
Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
CommitDate: Tue Jul 24 09:16:01 2018 +0100

    tools/gdbsx: fix build with clang 3.8
    
    Currently building gdbsx with clang 3.8 gives the following errors:
    
    xg_main.c:783:17: error: 'aligned' attribute ignored when parsing type 
[-Werror,-Wignored-attributes]
        iop->uva = (uint64_aligned_t)((unsigned long)tobuf);
                    ^~~~~~~~~~~~~~~~
    
/builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50:
 note: expanded from macro 'uint64_aligned_t'
                                                     ^~~~~~~~~~
    xg_main.c:816:17: error: 'aligned' attribute ignored when parsing type 
[-Werror,-Wignored-attributes]
        iop->uva = (uint64_aligned_t)((unsigned long)frombuf);
                    ^~~~~~~~~~~~~~~~
    
/builds/liuw/xen/tools/debugger/gdbsx/xg/../../../../tools/include/xen/arch-x86/xen-x86_32.h:105:50:
 note: expanded from macro 'uint64_aligned_t'
    
    According to https://bugs.llvm.org/show_bug.cgi?id=11071, this issue has
    been fixed in clang. But we're not going to get that in 3.8.
    
    Explicitly disable that warning to fix the build.
    
    Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
    Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 tools/debugger/gdbsx/Rules.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/debugger/gdbsx/Rules.mk b/tools/debugger/gdbsx/Rules.mk
index 6e38f2df99..920f1c87fb 100644
--- a/tools/debugger/gdbsx/Rules.mk
+++ b/tools/debugger/gdbsx/Rules.mk
@@ -2,3 +2,5 @@ include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS   += -Werror -Wmissing-prototypes 
 # (gcc 4.3x and later)   -Wconversion -Wno-sign-conversion
+
+CFLAGS-$(clang) += -Wno-ignored-attributes
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.